-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add ice-proxy example #3165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add ice-proxy example #3165
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
+ Coverage 78.53% 80.53% +2.00%
==========================================
Files 91 78 -13
Lines 11496 10552 -944
==========================================
- Hits 9028 8498 -530
+ Misses 1971 1606 -365
+ Partials 497 448 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b317c9f
to
c54a013
Compare
c54a013
to
dae3343
Compare
Great work @amanakin I would love to merge this! What is the purpose of TURN in the example? I don't understand the relationship of HTTP Proxying + TURN. Is it possible to do proxying using ice-tcp instead? Is TCP via TURN a requirement? |
Hey, yes, proxying is currently possible (and it makes sense) only via turn |
@Sean-Der |
@amanakin that would be great! Will make it significantly simpler. also love the in-server TURN example. I think it will be real useful :) |
@Sean-Der, I updated the example and added some clarifications to the readme. |
Description
This PR introduces an example demonstrating how to configure and use a proxy with ICE.