Skip to content

Add ice-proxy example #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

amanakin
Copy link

Description

This PR introduces an example demonstrating how to configure and use a proxy with ICE.

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (f5d98ce) to head (919a236).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3165      +/-   ##
==========================================
+ Coverage   78.53%   80.53%   +2.00%     
==========================================
  Files          91       78      -13     
  Lines       11496    10552     -944     
==========================================
- Hits         9028     8498     -530     
+ Misses       1971     1606     -365     
+ Partials      497      448      -49     
Flag Coverage Δ
go 80.53% <ø> (+0.14%) ⬆️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanakin amanakin force-pushed the add_proxy_example branch from b317c9f to c54a013 Compare June 20, 2025 10:48
@amanakin amanakin force-pushed the add_proxy_example branch from c54a013 to dae3343 Compare June 20, 2025 10:55
@amanakin amanakin marked this pull request as draft June 20, 2025 14:30
@Sean-Der
Copy link
Member

Sean-Der commented Jun 20, 2025

Great work @amanakin I would love to merge this!

What is the purpose of TURN in the example? I don't understand the relationship of HTTP Proxying + TURN.

Is it possible to do proxying using ice-tcp instead? Is TCP via TURN a requirement?

@amanakin
Copy link
Author

Great work @amanakin I would love to merge this!

What is the purpose of TURN in the example? I don't understand the relationship of HTTP Proxying + TURN.

Is it possible to do proxying using ice-tcp instead? Is TCP via TURN a requirement?

Hey, yes, proxying is currently possible (and it makes sense) only via turn
https://github.com/pion/ice/blame/master/gather.go#L706

@amanakin
Copy link
Author

@Sean-Der
I also want to update this example by using just two Pion clients, because the Chrome browser doesn't allow TURN requests to localhost. Maybe this is because of: https://localmess.github.io/ (By the way, in Firefox it works.)

@Sean-Der
Copy link
Member

@amanakin that would be great! Will make it significantly simpler.

also love the in-server TURN example. I think it will be real useful :)

@amanakin amanakin marked this pull request as ready for review June 23, 2025 14:30
@amanakin
Copy link
Author

@Sean-Der, I updated the example and added some clarifications to the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants