fuel scooping: improve algorithm

Surprisingly, time acceleration did not affect fuel scooping rate.

But if it was, scooping rate should be less than 1.0f to keep it
efficient since we have a random [0, 1) number compared with it.

In case of fuel_scoop_cap == 3, time acceleration == 10,
(speed * density > 10000) will bring scooping rate > 1.0f.

Enforcing time acceleration even further makes scooping much worse.

data/modules/FuelScoop.lua

@@ -12,11 +12,11 @@ local lc = Lang.GetResource("core")
 -- These callbacks are triggered from C++ or Lua and are responsible for
 -- providing UI feedback about the scooping process.
 
-Event.Register("onShipScoopFuel", function(ship, body)
+Event.Register("onShipScoopFuel", function(ship, body, amount)
 	---@type CargoManager
 	local cargoMgr = ship:GetComponent('CargoManager')
 
-	cargoMgr:AddCommodity(Commodities.hydrogen, 1)
+	cargoMgr:AddCommodity(Commodities.hydrogen, amount)
 
 	if ship == Game.player then
 		Game.AddCommsLogLine(lc.FUEL_SCOOP_ACTIVE_N_TONNES_H_COLLECTED:gsub('%%quantity',

src/Ship.cpp

@@ -1258,8 +1258,11 @@ void Ship::StaticUpdate(const float timeStep)
 				const double dot = vdir.Dot(pdir);
 				if ((m_stats.free_capacity) && (dot > 0.90) && (speed > 100.0) && (density > 0.3)) {
 					const double rate = speed * density * 0.00000333 * double(m_stats.fuel_scoop_cap);
-					if (Pi::rng.Double() < rate) {
-						LuaEvent::Queue("onShipScoopFuel", this, p);
+					m_hydrogenScoopedAccumulator += rate * Pi::game->GetTimeAccelRate();
+					if (m_hydrogenScoopedAccumulator > 1) {
+						const double scoopedTons = floor(m_hydrogenScoopedAccumulator);
+						LuaEvent::Queue("onShipScoopFuel", this, p, scoopedTons);
+						m_hydrogenScoopedAccumulator -= scoopedTons;
 					}
 				}
 			}

src/Ship.h

@@ -330,6 +330,8 @@ class Ship : public DynamicBody {
 
 	std::string m_shipName;
 
+	double m_hydrogenScoopedAccumulator = 0;
+
 public:
 	// FIXME: these methods are deprecated; all calls should use the propulsion object directly.
 	void ClearAngThrusterState() { m_propulsion->ClearAngThrusterState(); }