Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes and improvements #5968

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

sturnclaw
Copy link
Member

Another batch of "cleanup" work - this adds autocomplete suggestions for Input.RegisterAxis/ActionBinding, adds a CMake option to enable an address-sanitizer build, and cleans up some very unneeded header includes in core/StringName.h.

I think that was the last #include "profiler/Profiler.h" in a widely-used header, so I had to address quite a few files in the process.

- Don't directly use Profiler::Clock
- Don't include StringHash.h as hashing is done inside the cpp file
- Add profiler/Profiler.h to various .cpp files which didn't include it prior
- Remove some unneeded includes
- Ensure GalaxyGenerator.h doesn't require a prior include of Galaxy.h
- Don't query for equality to Pi::player in Ship-AI.cpp (removes need for Pi.h and Player.h includes)
@sturnclaw sturnclaw merged commit d56c32e into pioneerspacesim:master Nov 14, 2024
4 checks passed
@@ -99,6 +99,16 @@ if (USE_TIME_TRACE)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ftime-trace")
endif()

option(USE_ASAN "Use -fsanitize=asan when compiling (requires Clang)" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-fsanitize=address?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I overlooked that - this originally also had -fsanitize=thread as an option until I realized our codebase uses too many non-pthread synchronization primitives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants