Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More default colours and cleanup copy-n-paste in GeoPatch #5973

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

fluffyfreak
Copy link
Contributor

This is just a tidyup PR. no actual functionality changes

Copy link
Member

@sturnclaw sturnclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (tested) {
    merge();
}

@fluffyfreak
Copy link
Contributor Author

I realised I'd brought over the change from m_clipCentroid to m_centroid, and I'm glad I did because it's given me an idea.

Anyway, reverted that and it's good to go

@sturnclaw
Copy link
Member

Do you mind squashing your last two commits together? I'm not seeing a strong connection to the first one that would justify squashing the entire PR together.

@fluffyfreak fluffyfreak merged commit a841814 into pioneerspacesim:master Nov 17, 2024
@fluffyfreak fluffyfreak deleted the micro-tidying branch November 17, 2024 20:49
@sturnclaw
Copy link
Member

Tested, looks good to me - good catch on fixing the centroid being used 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants