Generalize to any OpenGL binding #6050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an unfortunate design of the FindOpenGL.cmake module, not specifying `COMPONENTS OpenGL` would fail for systems without GLX, and OPENGL_LIBRARIES would not be set, either.
|
FTR: The latest release of GLEW also doesn't compile against EGL and needs some minor Makefile modifications. So this will only be useful when GLEW releases a new version for EGL support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an unfortunate design of the FindOpenGL.cmake module, not specifying
COMPONENTS OpenGLwould fail for systems without GLX, and OPENGL_LIBRARIES would not be set, either.This should hopefully work for both now (until cmake modifies the module).