Fix MILITARY tech level display and availability. #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sturnclaw Please let me know if you would like color comparison for |
|
03633ea implements color comparison:
|
|
I need to take a deeper look at how we handle MILITARY tech level across all of the new outfitting code (that I wrote) - will review this PR quite soon with an eye to getting it in an upcoming hotfix, but will not be able to do so immediately. |
|
Sounds good. If you need anything from me in the meantime, I'm all ears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6039
RE #6046
This PR addresses two related issues:
MILITARYtech level causes a GUI crash inrenderCompareRow()inequipment-outfitter.luabecause it assumes a numeric value.MILITARY, inrenderCompareRow(), skip the level comparison (if applicable) and render the level as the police shield icon (see screenshot).equipment-outfitter.lua,stationHasTech()currently interpretsMILITARYas tech level 11, makingMILITARYequipment available in tech level 12 stations (e.g., Torvalds Platform).MILITARY, interpret the level as 11 as before, but only pass the check if the station's level is also 11. In addition, change the tech level for the S3 and S4 military drives toMILITARY.