Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Amazon Smile #8

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Enable support for Amazon Smile #8

merged 1 commit into from
Feb 3, 2018

Conversation

LandonSchropp
Copy link
Contributor

I tested this out locally and it seems to work great for both smile.amazon.com and www.amazon.com. You may want to test yourself just to be sure.

Closes #5.

@pip8786
Copy link
Owner

pip8786 commented Feb 1, 2018

Do you think we could add support for any Amazon url to this? Amazon.co.uk, Amazon.fr, etc. I guess we could just wildcard the top level domain?

I'll be trying to test your changes later tonight.

@pip8786
Copy link
Owner

pip8786 commented Feb 1, 2018

Also when I go to my payment options it brings me to this URL instead of gp/wallet.

https://www.amazon.com/cpe/managepaymentmethods

Is that not what you're seeing? The /gp/wallet URL still seems to work but i'm not sure how it's accessed. The extension only shows the nicknames on the latter.

@LandonSchropp
Copy link
Contributor Author

I thought about adding that, but I wasn't sure if you could wildcard the TLD part of the URL in the manifest.json file.

For the second point, I entered /gp/wallet directly into the URL. Maybe Amazon has added a new page?

@pip8786
Copy link
Owner

pip8786 commented Feb 2, 2018

Yeah, i think they must had cause I don't see a way to go to that page from links anymore. I'll have to add that to the update, I didn't get a chance to look at it yesterday so hopefully this weekend.

@pip8786 pip8786 merged commit e65b913 into pip8786:master Feb 3, 2018
@pip8786
Copy link
Owner

pip8786 commented Feb 3, 2018

I've merged this in. I wasn't exactly sure how to add to it so I ended up doing two pull requests to add the other domains and add the payment page. I'm going to update the metadata and then push it to the store. Hopefully it will show up in a few hours. Thanks for the contribution and getting me moving on this!

@LandonSchropp
Copy link
Contributor Author

LandonSchropp commented Feb 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants