Fix to use plugins

Signed-off-by: Yoshiki Fujikane <[email protected]>

pkg/app/pipedv1/apistore/applicationstore/store.go

@@ -149,8 +149,11 @@ func (s *store) ListByPluginName(name string) []*model.Application {
 	list := apps.([]*model.Application)
 
 	for _, app := range list {
-		if app.Plugin == name {
-			out = append(out, app)
+		for _, p := range app.Plugins {
+			if p == name {
+				out = append(out, app)
+				break
+			}
 		}
 	}
 

pkg/app/pipedv1/apistore/applicationstore/store_test.go

@@ -0,0 +1,89 @@
+// Copyright 2024 The PipeCD Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package applicationstore
+
+import (
+	"testing"
+
+	"go.uber.org/atomic"
+	"go.uber.org/zap/zaptest"
+
+	"github.com/pipe-cd/pipecd/pkg/model"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestListByPluginName(t *testing.T) {
+	logger := zaptest.NewLogger(t)
+
+	tests := []struct {
+		name       string
+		storedApps []*model.Application
+		plugin     string
+		expected   []*model.Application
+	}{
+		{
+			name:       "There is no stored application",
+			storedApps: []*model.Application{},
+			plugin:     "plugin-a",
+			expected:   []*model.Application{},
+		},
+		{
+			name: "no matching",
+			storedApps: []*model.Application{
+				{Id: "app-1", Plugins: []string{"plugin-b"}},
+				{Id: "app-2", Plugins: []string{"plugin-c"}},
+			},
+			plugin:   "plugin-a",
+			expected: []*model.Application{},
+		},
+		{
+			name: "one matched application",
+			storedApps: []*model.Application{
+				{Id: "app-1", Plugins: []string{"plugin-a", "plugin-b"}},
+				{Id: "app-2", Plugins: []string{"plugin-b"}},
+			},
+			plugin: "plugin-a",
+			expected: []*model.Application{
+				{Id: "app-1", Plugins: []string{"plugin-a", "plugin-b"}},
+			},
+		},
+		{
+			name: "matched some applications",
+			storedApps: []*model.Application{
+				{Id: "app-1", Plugins: []string{"plugin-a", "plugin-b"}},
+				{Id: "app-2", Plugins: []string{"plugin-a"}},
+				{Id: "app-3", Plugins: []string{"plugin-b"}},
+			},
+			plugin: "plugin-a",
+			expected: []*model.Application{
+				{Id: "app-1", Plugins: []string{"plugin-a", "plugin-b"}},
+				{Id: "app-2", Plugins: []string{"plugin-a"}},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			s := &store{
+				applicationList: atomic.Value{},
+				logger:          logger,
+			}
+			s.applicationList.Store(tt.storedApps)
+
+			got := s.ListByPluginName(tt.plugin)
+			assert.Equal(t, tt.expected, got)
+		})
+	}
+}

pkg/model/application.proto

@@ -45,8 +45,8 @@ message Application {
     string platform_provider = 15;
     // The names of deploy taget where to deploy this application.
     repeated string deploy_targets = 16;
-    // The name of plugin used to deploy this application.
-    string plugin = 17;
+    // The names of plugin used to deploy this application.
+    repeated string plugins = 17;
     // Additional description about application.
     string description = 9;
     // Custom attributes to identify applications.

web/model/application_pb.d.ts

@@ -37,8 +37,10 @@ export class Application extends jspb.Message {
   clearDeployTargetsList(): Application;
   addDeployTargets(value: string, index?: number): Application;
 
-  getPlugin(): string;
-  setPlugin(value: string): Application;
+  getPluginsList(): Array<string>;
+  setPluginsList(value: Array<string>): Application;
+  clearPluginsList(): Application;
+  addPlugins(value: string, index?: number): Application;
 
   getDescription(): string;
   setDescription(value: string): Application;
@@ -98,7 +100,7 @@ export namespace Application {
     cloudProvider: string,
     platformProvider: string,
     deployTargetsList: Array<string>,
-    plugin: string,
+    pluginsList: Array<string>,
     description: string,
     labelsMap: Array<[string, string]>,
     mostRecentlySuccessfulDeployment?: ApplicationDeploymentReference.AsObject,

web/src/__fixtures__/dummy-application.ts

@@ -26,7 +26,7 @@ export const dummyApplication: Application.AsObject = {
   cloudProvider: "",
   platformProvider: "kubernetes-default",
   deployTargetsList: ["kubernetes-default"],
-  plugin: "",
+  pluginsList: ["kubernetes"],
   disabled: false,
   gitPath: {
     configFilename: "",
@@ -134,6 +134,7 @@ export function createApplicationFromObject(
   app.setId(o.id);
   app.setPlatformProvider(o.platformProvider);
   app.setDeployTargetsList(o.deployTargetsList);
+  app.setPluginsList(o.pluginsList);
   app.setDisabled(o.disabled);
   app.setKind(o.kind);
   app.setName(o.name);