[ECS] Support 5 missing fields in TaskDefinition (#5424)

* Add missing fields in RegisterTaskDef Signed-off-by: t-kikuc <[email protected]> * remove two restrictions Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
pipe-cd · Dec 16, 2024 · 0e4fbc0 · 0e4fbc0
1 parent 5e1a7f5
commit 0e4fbc0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/docs/content/en/docs-dev/user-guide/configuration-reference.md b/docs/content/en/docs-dev/user-guide/configuration-reference.md
@@ -538,8 +538,6 @@ There are some restrictions in configuring a service definition file.
 
 There are some restrictions in configuring a task definition file.
 
-- `placementConstraints` is not supported.
-- `proxyConfiguration` is not supported.
 - `tags` is not supported.
 
 ### ECSTargetGroupInput

diff --git a/pkg/app/piped/platformprovider/ecs/client.go b/pkg/app/piped/platformprovider/ecs/client.go
@@ -188,9 +188,15 @@ func (c *client) RegisterTaskDefinition(ctx context.Context, taskDefinition type
 		Volumes:                 taskDefinition.Volumes,
 		RuntimePlatform:         taskDefinition.RuntimePlatform,
 		EphemeralStorage:        taskDefinition.EphemeralStorage,
-		// Requires defined at task level in case Fargate is used.
+		// Cpu and Memory must be defined if Fargate is used.
 		Cpu:    taskDefinition.Cpu,
 		Memory: taskDefinition.Memory,
+
+		InferenceAccelerators: taskDefinition.InferenceAccelerators,
+		IpcMode:               taskDefinition.IpcMode,
+		PidMode:               taskDefinition.PidMode,
+		PlacementConstraints:  taskDefinition.PlacementConstraints,
+		ProxyConfiguration:    taskDefinition.ProxyConfiguration,
 		// TODO: Support tags for registering task definition.
 	}
 	output, err := c.ecsClient.RegisterTaskDefinition(ctx, input)