Skip to content

Commit

Permalink
Add a comment for ECS Rollback for ServiceDiscovery
Browse files Browse the repository at this point in the history
Signed-off-by: t-kikuc <[email protected]>
  • Loading branch information
t-kikuc committed Nov 28, 2023
1 parent f071bfb commit 8f22ec0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/app/piped/executor/ecs/rollback.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ func (e *rollbackExecutor) ensureRollback(ctx context.Context) model.StageStatus
if !ok {
return model.StageStatus_STAGE_FAILURE
}
// Even if target groups are not found, we can continue to rollback.
// So the accessType does not matter here.

if !rollback(ctx, &e.Input, platformProviderName, platformProviderCfg, taskDefinition, serviceDefinition, primary, canary) {
return model.StageStatus_STAGE_FAILURE
Expand Down

0 comments on commit 8f22ec0

Please sign in to comment.