-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce script run stage #4643
Comments
TODO
|
📝
|
refer the implementation |
📝 Share my current opinion when to rollback :) Behavior during rollback of SCRIPT_RUN
For example, consider when deployment proceeds in the following order from 1 to 7.
Then
How to realize it We can choose 2 ways to realize the rollback.
|
@ffjlabo I want to vote for (2) We're going to have a plugin for each platform, in such case, each platform ROLLBACK stage implementation would be run/implemented by the plugin author. At the time the plugin is implemented, there would be no way for them to notice that the ROLLBACK stage has to be called the ROLLBACK_SCRIPTRUN. For simplicity, ROLLBACK stage for the platform should only focus on ROLLBACK for platform, ROLLBACK_SCRIPTRUN should be implemented by SCRIPTRUN executor. |
Another way to think is, if we treat this SCRIPT_RUN as a plugin for piped, then it should provide its ROLLBACK, not rely on other stages/platform ROLLBACK. |
Thank you for your opinion :) I got it! |
Currently, k8s only. I will apply it to other kind of apps. |
📝 It might be nice to have the option to ignore the failure on the stage. |
for ECS app request: #4813 |
Related issue: #4814 |
What would you like to be added:
follow: #1089
implement stage to execute any command.
Why is this needed:
The text was updated successfully, but these errors were encountered: