Fix docs for on rollback for script run #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4774 +/- ##
==========================================
- Coverage 31.03% 30.99% -0.04%
==========================================
Files 225 225
Lines 26353 26353
==========================================
- Hits 8179 8169 -10
- Misses 17521 17530 +9
- Partials 653 654 +1 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Feb 6, 2024
| @@ -8,12 +8,11 @@ description: > | |||
|
|
|||
| `SCRIPT_RUN` stage is one stage in the pipeline and you can execute any commands. | |||
|
|
|||
| > Note: This feature is at the alpha status. | |||
| > Note: This feature is at the alpha status and only for the application kind of KubernetesApp. | |||
There was a problem hiding this comment.
Suggested change
| > Note: This feature is at the alpha status and only for the application kind of KubernetesApp. | |
| > Note: This feature is at the alpha status and currently only for the application kind of KubernetesApp. |
There was a problem hiding this comment.
@khanhtc1202
Thank you! Forgot to add it 🙏
Added :) 3714161
Signed-off-by: Yoshiki Fujikane <[email protected]>
t-kikuc
approved these changes
Feb 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix docs for on rollback for script run.
onRollbackSCRIPT_RUNstageWhich issue(s) this PR fixes:
Part of #4643
Does this PR introduce a user-facing change?: