Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent running standalone ECS tasks during deployment #4665

Closed
kentakozuka opened this issue Nov 9, 2023 · 2 comments · Fixed by #4666
Closed

Prevent running standalone ECS tasks during deployment #4665

kentakozuka opened this issue Nov 9, 2023 · 2 comments · Fixed by #4666
Labels
area/piped kind/enhancement New feature or request

Comments

@kentakozuka
Copy link
Member

kentakozuka commented Nov 9, 2023 •
edited
Loading

What would you like to be added:

Prevent standalone ECS tasks from running at the deployment.
Adding a flag ECSApp.runAtDeployment to disable running at the deployment...?

Why is this needed:

There is the case;

  • Run a task at a certain time triggered by EventBridge.
  • The task should not be triggered at the deployment.

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/scheduled_tasks-eventbridge-scheduler.html
@kentakozuka kentakozuka added the kind/enhancement New feature or request label Nov 9, 2023
@kentakozuka kentakozuka changed the title Prevent standalone ECS task from running at the deployment Prevent running standalone ECS tasks during deployment Nov 9, 2023
@kentakozuka
Copy link
Member Author

Current implementation;

  1. Check if the service definition exists.
  2. If not, Run the task.
    code is here

@kentakozuka kentakozuka mentioned this issue Nov 9, 2023
Merged
@kentakozuka
Copy link
Member Author

kentakozuka commented Nov 9, 2023 •
edited
Loading

Created a draft PR #4666. PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/piped kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a flag to skip running standalone task during deployment kentakozuka/pipecd
1 participant
@kentakozuka