Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to skip running standalone task during deployment #4666

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add a flag to skip running standalone task during deployment #4666

merged 2 commits into from
Nov 10, 2023

Conversation

kentakozuka
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4665

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@kentakozuka kentakozuka mentioned this pull request Nov 9, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89fb203) 30.81% compared to head (ad7682a) 30.81%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4666      +/-   ##
==========================================
- Coverage   30.81%   30.81%   -0.01%     
==========================================
  Files         221      221              
  Lines       25941    25941              
==========================================
- Hits         7995     7993       -2     
- Misses      17296    17298       +2     
  Partials      650      650
Files Coverage Δ
pkg/config/application_ecs.go 9.52% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc
Copy link
Member

t-kikuc commented Nov 9, 2023

Successfully the codes @kentakozuka suggested worked in my dev environment!

@kentakozuka
Fix docs
ad7682a 
Signed-off-by: Kenta Kozuka <[email protected]>
@kentakozuka kentakozuka marked this pull request as ready for review November 9, 2023 13:29
khanhtc1202
khanhtc1202 reviewed Nov 9, 2023
View reviewed changes
pkg/app/piped/executor/ecs/ecs.go
Comment on lines +202 to +205
if !*ecsInput.RunStandaloneTask {
in.LogPersister.Infof("Skipped running task")
return true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, with this change, the task would not be "even" created at the time piped "sync" the ECS app. We can expect other triggers to start the tasks for us, is that right? In such case, how can that trigger specify the exact taskDefinition revision to use to create the ECS task 🤔 WDYT @kentakozuka @nnnkkk7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can expect other triggers to start the tasks for us, is that right?

Yes. We need other triggers to start the task.

In such case, how can that trigger specify the exact taskDefinition revision to use to create the ECS task

AFAIK, EventBridge Scheduler allows us to select the latest revision or specific one to run.

Untitled (1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I understand that they allow us to do that, but the point is how actually dev can understand that which revision of taskdef is what they want (if they create it not of the time they commit the code change). Anw, it's just my concern on how actually this function could be used in usecase, look like it not really pipecd problem (if both of you agree with that way to select revision). Besides, maybe print out registered taskdef revision on stage log could help.

khanhtc1202
khanhtc1202 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kentakozuka kentakozuka merged commit 7ccfb76 into pipe-cd:master Nov 10, 2023
12 of 13 checks passed
@kentakozuka kentakozuka deleted the ecs-standalone-task branch November 10, 2023 04:03
kentakozuka added a commit that referenced this pull request Nov 10, 2023
@kentakozuka
Add a flag to skip running standalone task during deployment (#4666)
c351316 
* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
@ffjlabo ffjlabo mentioned this pull request Nov 13, 2023
Merged
ffjlabo pushed a commit that referenced this pull request Nov 13, 2023
@kentakozuka @ffjlabo
Add a flag to skip running standalone task during deployment (#4666)
bf9c092 
* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
khanhtc1202 added a commit that referenced this pull request Nov 13, 2023
@ffjlabo @dependabot
@khanhtc1202 @karamaru-alpha @kentakozuka @mi11km @seitarof @TakumaKurosawa
Cherry-pick #4611 #4612 #4613 #4619 #4621 #4622 #4624 #4625 #4626 #4627
e2e214b 
#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669)

* Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Tran <[email protected]>

* Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0.
- [Commits](golang/net@v0.8.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619)

* Fix part of lint/go errors (misspell, depguard, unconvert) (#4621)

* Fix lint/go errors (misspell)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (depguard)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (unconvert)

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622)

* Fix lint/go errors (goimport)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (staticcheck)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (gosimple)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (gosimple)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix return error by function

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624)

* Ignore mannwhitney from golangci-lint

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (deadcode)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (depguard)

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Add tests to terraform platform provider (#4625)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to apikey model (#4626)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to application model (#4627)

Signed-off-by: Kenta Kozuka <[email protected]>

* Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628)

* Add GOCACHE env to lint/go

Signed-off-by: karamaru-alpha <[email protected]>

* Add verbose flag to lint/go

Signed-off-by: karamaru-alpha <[email protected]>

* Change timeout golangci.yml

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Add tests to model/deployment (#4629)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to model/notificationevent (#4631)

* Add tests to model/notificationevent

Signed-off-by: Kenta Kozuka <[email protected]>

* Add Parallel()

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to model/deployment_chain (#4632)

* Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633)

* Bump google.golang.org/grpc from 1.54.0 to 1.56.3

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.54.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update grpc test version

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: khanhtc1202 <[email protected]>

* Fix lint/go errors (gocritic) (#4637)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (stylecheck)  (#4638)

* Fix lint/go errors (stylecheck)

Signed-off-by: karamaru-alpha <[email protected]>

* Remove nolint:stylecheck

Signed-off-by: karamaru-alpha <[email protected]>

* Change method reveiver name

Signed-off-by: karamaru-alpha <[email protected]>

* Change receiver name k to ak

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Bump github.com/docker/docker (#4641)

* Make actions plan preview handle timeout option (#4648)

* Format and make tests pass in tool/actions-plan-preview

Signed-off-by: mi11km <[email protected]>

* Use --piped-handle-timeout to make the timeout arg activate

Signed-off-by: mi11km <[email protected]>

* Add tests to model/notificationevent (#4631)

* Add tests to model/notificationevent

Signed-off-by: Kenta Kozuka <[email protected]>

* Add Parallel()

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: mi11km <[email protected]>

* add piped-handle-timeout(input args)

Signed-off-by: mi11km <[email protected]>

---------

Signed-off-by: mi11km <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>

* Fix panic error in ListDeployments API (#4650)

* Update golangci-lint and fix lint errors (#4656)

Signed-off-by: karamaru-alpha <[email protected]>

* Send error comment before plan preview exit (#4658)

* Send error comment before plan preview exit

Signed-off-by: Takumaron <[email protected]>

* Apply review commnet

Signed-off-by: Takumaron <[email protected]>

---------

Signed-off-by: Takumaron <[email protected]>

* Handle plan preview workflow's error and exit with error status code (#4662)

* Add a flag to skip running standalone task during deployment (#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: karamaru-alpha <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: mi11km <[email protected]>
Signed-off-by: Takumaron <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: karamaru <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: khanhtc1202 <[email protected]>
Co-authored-by: Masafumi Ikeyama <[email protected]>
Co-authored-by: Seitaro Fujigaki <[email protected]>
Co-authored-by: Kurosawa Takuma <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Merged
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
@kentakozuka @sZma5a
Add a flag to skip running standalone task during deployment (pipe-cd…
eec8a15 
…#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
@kentakozuka @sZma5a
Add a flag to skip running standalone task during deployment (pipe-cd…
ea9e3ea 
…#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
@kentakozuka @sZma5a
Add a flag to skip running standalone task during deployment (pipe-cd…
c65fa0b 
…#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: sZma5a <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Merged
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
@kentakozuka
Add a flag to skip running standalone task during deployment (pipe-cd…
d05dad4 
…#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-kikuc t-kikuc t-kikuc left review comments

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

@ffjlabo ffjlabo Awaiting requested review from ffjlabo ffjlabo is a code owner

Assignees
No one assigned
Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent running standalone ECS tasks during deployment
3 participants
@kentakozuka @t-kikuc @khanhtc1202