Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All changes are listed as internal changes #5024

Open
Warashi opened this issue Jul 4, 2024 · 3 comments
Open

All changes are listed as internal changes #5024

Warashi opened this issue Jul 4, 2024 · 3 comments
Assignees
Labels
area/tool kind/bug Something isn't working

Comments

@Warashi
Copy link
Contributor

Warashi commented Jul 4, 2024

What happened:

All changes are listed as internal changes.
ref; #5023 (comment)

What you expected to happen:

The PR labels in the config file are listed as not internal changes.

pipecd/RELEASE

Lines 8 to 18 in f71f39c

commitCategories:
- title: "Breaking Changes"
contains:
- change-category/breaking-change
- title: "New Features"
contains:
- change-category/new-feature
- title: "Notable Changes"
contains:
- change-category/notable-change
- title: "Internal Changes"

Currently, we have to include the configured message in the commit body.
But we sometimes want to label the PR after it's merged.

How to reproduce it:

Create release notes with the acitons-gh-release with changes that PR has non-internal changes label.

Environment:

  • piped version:
  • control-plane version:
  • Others:
@Warashi Warashi added the kind/bug Something isn't working label Jul 4, 2024
@t-kikuc t-kikuc self-assigned this Sep 26, 2024
@t-kikuc
Copy link
Member

t-kikuc commented Sep 26, 2024

let me try 🤾

@t-kikuc t-kikuc added this to ROADMAP Oct 4, 2024
@t-kikuc t-kikuc moved this to 🤔 In voting in ROADMAP Oct 4, 2024
@ffjlabo ffjlabo added this to v0.50.0 Oct 23, 2024
@t-kikuc
Copy link
Member

t-kikuc commented Nov 11, 2024

The cause is that tool/actions-gh-release supports only subjects and bodies, not labels.

The solution might be one of:

  • A. Use githubClient to fetch labels when listing commits instead of general git commands.
  • B. Inject attached labels into a squash merge commit.
    • Cons: Labels attached after merging will be ignored.

@t-kikuc
Copy link
Member

t-kikuc commented Nov 22, 2024

Let me postpone this issue. The reasons are:

  1. Prioritize developing the plugin
  2. We need to change the release flow after releasing the plugin arch

@t-kikuc t-kikuc removed the status in v0.50.0 Nov 22, 2024
@t-kikuc t-kikuc removed this from v0.50.0 Nov 22, 2024
@t-kikuc t-kikuc moved this from 🤔 In voting to 🌮 Postponed in ROADMAP Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tool kind/bug Something isn't working
Projects
Status: 🌮 Postponed
Development

Successfully merging a pull request may close this issue.

2 participants