Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions-gh-release] Add labels option in commitCategories #5327

Closed
wants to merge 1 commit into from

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Nov 11, 2024

What this PR does:

Enabled to categorize PRs by their labels.

Why we need it:

  • Currently, only prefix and body are supported for matching commitCategories.
  • Labels are more useful than commit body/prefixes.
    Especially, we can add labels even after merging commits.

Note:

We need the following steps to fix the issue.

  1. Merge this PR
  2. Release a new version of /tool/actions-gh-release in this repo [Added]
  3. Merge Add docs of labels in commitCategories actions-gh-release#36
  4. Release a new version of pipe-cd/actions-gh-release
  5. Update the RELEASE file: contains to labels

Which issue(s) this PR fixes:

Fixes #5024

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.28%. Comparing base (920620e) to head (6102e24).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5327      +/-   ##
==========================================
+ Coverage   25.25%   25.28%   +0.02%     
==========================================
  Files         444      444              
  Lines       47554    47554              
==========================================
+ Hits        12012    12022      +10     
+ Misses      34599    34590       -9     
+ Partials      943      942       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@t-kikuc
Copy link
Member Author

t-kikuc commented Nov 12, 2024

I'll make it Ready-for-review after testing.

@t-kikuc
Copy link
Member Author

t-kikuc commented Nov 22, 2024

Postpone.

@t-kikuc t-kikuc closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All changes are listed as internal changes
1 participant