-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rfc for pipectl init #4672
Add rfc for pipectl init #4672
Conversation
d5863b1
to
a0824bd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4672 +/- ##
==========================================
- Coverage 30.84% 30.82% -0.02%
==========================================
Files 221 221
Lines 25993 25935 -58
==========================================
- Hits 8018 7995 -23
+ Misses 17325 17290 -35
Partials 650 650 ☔ View full report in Codecov by Sentry. |
Is it only app.pipecd.yaml that the first step(1. Create a configuration file from scratch) creates? |
#4672 (comment) |
As you mentions here, would it be better to generate app.pipecd.yaml from applications's configs? apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
input:
# Specify the namespace if needed; otherwise, PipeCD deploys to the default namespace
namespace: default
kubernetes:
manifests:
- deployment.yaml
- service.yaml
pipeline:
stages:
# The primary deployment rollout
- name: K8S_PRIMARY_ROLLOUT
# The stage for manual approval (if needed)
- name: WAIT_APPROVAL
# The canary deployment rollout
- name: K8S_CANARY_ROLLOUT
with:
replicas: 50% # Adjust the percentage as required
# The cleanup stage for the canary deployment
- name: K8S_CANARY_CLEAN
trafficRouting:
method: pod
kubernetes:
primary:
labels:
pipecd.dev/variant: primary
canary:
labels:
pipecd.dev/variant: canary
Or applications all configs are created by pipectl based on the answers 🤔 |
I think it should have both features. |
@ouchi2501 Sounds very cool! Let's stick with your plan :) |
Signed-off-by: uncle <[email protected]>
Signed-off-by: uncle <[email protected]>
a0824bd
to
29d31c5
Compare
* Add rfc for pipectl init Signed-off-by: uncle <[email protected]> * fix typo Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]>
* Add rfc for pipectl init Signed-off-by: uncle <[email protected]> * fix typo Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]>
* Add rfc for pipectl init Signed-off-by: uncle <[email protected]> * fix typo Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]> Signed-off-by: sZma5a <[email protected]>
* Add rfc for pipectl init Signed-off-by: uncle <[email protected]> * fix typo Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
What this PR does / why we need it:
Add init to the pipectl command.
See below for Discussion.
#4635
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: