Add rfc for ECS not under ELB (Issue#4616) #4676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4676 +/- ##
==========================================
+ Coverage 30.82% 30.84% +0.01%
==========================================
Files 221 221
Lines 25935 25935
==========================================
+ Hits 7995 7999 +4
+ Misses 17290 17286 -4
Partials 650 650 ☔ View full report in Codecov by Sentry. |
|
I'll modify DCO and |
|
@t-kikuc please sign the commit with |
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
force-pushed
the
add-rfc-ecs-not-under-elb
branch
from
ea997b7 to
8711db2
Compare
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
force-pushed
the
add-rfc-ecs-not-under-elb
branch
from
0795a3d to
14d7e4e
Compare
|
@khanhtc1202 thank you. |
Signed-off-by: t-kikuc <[email protected]>
|
This is the canary deployment flow in RFC (GitHub fails to render):
|
|
This is the blue/green deployment flow in RFC (GitHub fails to render):
|
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To support progressive delivery for ECS without ELB.
It's not so big change, but I think ECS users will be affected in the future.
Which issue(s) this PR fixes:
Part of #4616
Does this PR introduce a user-facing change?: