add ephemeralStorage option to lambda config #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnnkkk7
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]>
nnnkkk7
force-pushed
the
add-ephemeralStorage-option-to-lambda
branch
from
1784872 to
38791cf
Compare
khanhtc1202
reviewed
Nov 21, 2023
| @@ -278,6 +281,9 @@ func (c *client) updateFunctionConfiguration(ctx context.Context, fm FunctionMan | |||
| if fm.Spec.Handler != "" { | |||
| configInput.Handler = aws.String(fm.Spec.Handler) | |||
| } | |||
| if fm.Spec.EphemeralStorage.Size != 0 { | |||
There was a problem hiding this comment.
Suggested change
| if fm.Spec.EphemeralStorage.Size != 0 { | |
| if fm.Spec.EphemeralStorage != nil && fm.Spec.EphemeralStorage.Size != 0 { |
avoid nil pointer error due to the omitempty json tag
There was a problem hiding this comment.
Thank you! I added it.
add nil pointer check
|
@nnnkkk7 Thanks for the contribution. For this configuration, should we also add this to |
Signed-off-by: nnnkkk7 <[email protected]>
Signed-off-by: nnnkkk7 <[email protected]>
|
@khanhtc1202 |
khanhtc1202
reviewed
Nov 23, 2023
| @@ -100,6 +103,11 @@ func (fmp FunctionManifestSpec) validate() error { | |||
| return fmt.Errorf("architecture is invalid: %w", err) | |||
| } | |||
| } | |||
| if fmp.EphemeralStorage != nil && fmp.EphemeralStorage.Size != 0 { | |||
There was a problem hiding this comment.
This condition is wrong 🤔 If the size value is set to 0 the validate function will be bypass.
Suggested change
| if fmp.EphemeralStorage != nil && fmp.EphemeralStorage.Size != 0 { | |
| if fmp.EphemeralStorage != nil { |
There was a problem hiding this comment.
Thank you!
I fixed these conditions! fix condition
khanhtc1202
reviewed
Nov 23, 2023
khanhtc1202
reviewed
Nov 23, 2023
khanhtc1202
reviewed
Nov 23, 2023
Signed-off-by: nnnkkk7 <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4680 +/- ##
==========================================
+ Coverage 30.82% 30.84% +0.01%
==========================================
Files 221 221
Lines 25935 25952 +17
==========================================
+ Hits 7995 8004 +9
- Misses 17289 17298 +9
+ Partials 651 650 -1 ☔ View full report in Codecov by Sentry. |
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Dec 1, 2023
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Dec 1, 2023
* add ephemeralStorage option to lambda config (#4680) * add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> * Add v2 to versionWhitelist (#4682) Signed-off-by: Yoshiki Fujikane <[email protected]> * [ECS] Tag to the new taskset in rollback (fixes #4692) (#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix #4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: naoki kuroda <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: sZma5a <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
* add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I added an ephemeralStorage optional value to the lambda configuration.
Which issue(s) this PR fixes:
Fixes #4679
Does this PR introduce a user-facing change?:
No