cover gcr.io/pipecd and ghcr.io/pipe-cd #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hungran <[email protected]>
hungran
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4719 +/- ##
==========================================
+ Coverage 30.82% 30.84% +0.02%
==========================================
Files 221 221
Lines 25993 25993
==========================================
+ Hits 8012 8018 +6
+ Misses 17331 17325 -6
Partials 650 650 ☔ View full report in Codecov by Sentry. |
|
Umm... the workflow is not working... 🤔 |
|
@hungran ref: https://github.com/orgs/community/discussions/26698#discussioncomment-7564287 |
eg: Dockefile-okd Signed-off-by: hungran <[email protected]>
hungran
force-pushed
the
hungran/fix-image-build-matrix
branch
from
a342698 to
ef02baa
Compare
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* cover gcr.io/pipecd and ghcr.io/pipe-cd Signed-off-by: hungran <[email protected]> * iamge okd should have prefix -okd eg: Dockefile-okd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* cover gcr.io/pipecd and ghcr.io/pipe-cd Signed-off-by: hungran <[email protected]> * iamge okd should have prefix -okd eg: Dockefile-okd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* cover gcr.io/pipecd and ghcr.io/pipe-cd Signed-off-by: hungran <[email protected]> * iamge okd should have prefix -okd eg: Dockefile-okd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: sZma5a <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* cover gcr.io/pipecd and ghcr.io/pipe-cd Signed-off-by: hungran <[email protected]> * iamge okd should have prefix -okd eg: Dockefile-okd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: sZma5a <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
* cover gcr.io/pipecd and ghcr.io/pipe-cd Signed-off-by: hungran <[email protected]> * iamge okd should have prefix -okd eg: Dockefile-okd Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
fix PR #4712 and #4718
Test from my repo
10 jobs
7 job ghcr.io/pipe-cd
3 job gcr.io/pipecd for
helloworld,launcherandpipedFixes #
Does this PR introduce a user-facing change?: