Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] Modify ELB listener rules other than defaults without adding config #4733

Merged
merged 9 commits into from
Dec 27, 2023

Modify loop variable name in test

fd13dff
Select commit
Loading
Failed to load commit list.
Merged

[ECS] Modify ELB listener rules other than defaults without adding config #4733

Modify loop variable name in test
fd13dff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 27, 2023 in 1s

24.07% of diff hit (target 30.84%)

View this Pull Request on Codecov

24.07% of diff hit (target 30.84%)

Annotations

Check warning on line 442 in pkg/app/piped/platformprovider/ecs/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L441-L442 

Added lines #L441 - L442 were not covered by tests

Check warning on line 445 in pkg/app/piped/platformprovider/ecs/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L445 

Added line #L445 was not covered by tests

Check warning on line 465 in pkg/app/piped/platformprovider/ecs/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L448-L465 

Added lines #L448 - L465 were not covered by tests

Check warning on line 471 in pkg/app/piped/platformprovider/ecs/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L468-L471 

Added lines #L468 - L471 were not covered by tests

Check warning on line 491 in pkg/app/piped/platformprovider/ecs/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/piped/platformprovider/ecs/client.go#L476-L491 

Added lines #L476 - L491 were not covered by tests
View more details on Codecov