Revert "Copy platform provider kubernetes under the plugin directory" #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5253 +/- ##
==========================================
+ Coverage 23.89% 24.03% +0.13%
==========================================
Files 455 439 -16
Lines 49146 47017 -2129
==========================================
- Hits 11745 11301 -444
+ Misses 36453 34813 -1640
+ Partials 948 903 -45 ☔ View full report in Codecov by Sentry. |
|
Need DCO signoff 👀 cc @Warashi |
…5250)" This reverts commit c866fa3. Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
force-pushed
the
revert-5250-pipedv1-k8s-plugin-copy-platformproviders
branch
from
495fc7d to
99e7f62
Compare
|
Thanks for notifying me. |
t-kikuc
approved these changes
Oct 7, 2024
Warashi
deleted the
revert-5250-pipedv1-k8s-plugin-copy-platformproviders
branch
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5250
We decide not to copy all platformprovider codes, but to copy each time it is needed.