Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloud Providers related docs #5279

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Remove Cloud Providers related docs #5279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 0 additions & 134 deletions docs/content/en/docs-dev/user-guide/managing-piped/adding-a-cloud-provider.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions docs/content/en/docs-dev/user-guide/managing-piped/configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ spec:
| repositories | [][Repository](#gitrepository) | List of Git repositories this piped will handle. | No |
| chartRepositories | [][ChartRepository](#chartrepository) | List of Helm chart repositories that should be added while starting up. | No |
| chartRegistries | [][ChartRegistry](#chartregistry) | List of helm chart registries that should be logged in while starting up. | No |
| cloudProviders | [][CloudProvider](#cloudprovider) | List of cloud providers can be used by this piped. This field is deprecated, use `platformProviders` instead. | No |
| platformProviders | [][PlatformProvider](#platformprovider) | List of platform providers can be used by this piped. | No |
| analysisProviders | [][AnalysisProvider](#analysisprovider) | List of analysis providers can be used by this piped. | No |
| eventWatcher | [EventWatcher](#eventwatcher) | Optional Event watcher settings. | No |
Expand Down Expand Up @@ -81,10 +80,6 @@ spec:
| username | string | Username used for the registry authentication. | No |
| password | string | Password used for the registry authentication. | No |

## CloudProvider

This field is deprecated, please use [PlatformProvider](#platformprovider) instead.

## PlatformProvider

| Field | Type | Description | Required |
Expand Down
134 changes: 0 additions & 134 deletions docs/content/en/docs-v0.49.x/user-guide/managing-piped/adding-a-cloud-provider.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, it's better to leave v0.49.x docs because we promise the patch releases don't include breaking changes.

pipecd/RELEASES.md

Line 50 in 45e18f7

This may also contain some minor features, but ensure that it does NOT contain any breaking changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, I only want to not mention the CloudProviders in docs to less confuse the newcomers. The old users have already known about the CloudProviders -> PlatformProviders for a while now (we could assume that since this config was marked as deprecated 2 years ago). So I think remove the docs is okay, it's also not a breaking change or any

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I got your point.

This file was deleted.

5 changes: 0 additions & 5 deletions docs/content/en/docs-v0.49.x/user-guide/managing-piped/configuration-reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ spec:
| repositories | [][Repository](#gitrepository) | List of Git repositories this piped will handle. | No |
| chartRepositories | [][ChartRepository](#chartrepository) | List of Helm chart repositories that should be added while starting up. | No |
| chartRegistries | [][ChartRegistry](#chartregistry) | List of helm chart registries that should be logged in while starting up. | No |
| cloudProviders | [][CloudProvider](#cloudprovider) | List of cloud providers can be used by this piped. This field is deprecated, use `platformProviders` instead. | No |
| platformProviders | [][PlatformProvider](#platformprovider) | List of platform providers can be used by this piped. | No |
| analysisProviders | [][AnalysisProvider](#analysisprovider) | List of analysis providers can be used by this piped. | No |
| eventWatcher | [EventWatcher](#eventwatcher) | Optional Event watcher settings. | No |
Expand Down Expand Up @@ -81,10 +80,6 @@ spec:
| username | string | Username used for the registry authentication. | No |
| password | string | Password used for the registry authentication. | No |

## CloudProvider

This field is deprecated, please use [PlatformProvider](#platformprovider) instead.

## PlatformProvider

| Field | Type | Description | Required |
Expand Down
Loading