Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LoadPlainYAMLManifests and LoadManifests #5284

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 21, 2024

What this PR does:

  • add below implementations of the k8s plugin
    • Implement LoadPlainYAMLManifests
    • Implement LoadManifests partially

Why we need it:

  • We have to load k8s manifests to determine SYNC_STRATEGY, and do other k8s operations.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 46.61017% with 63 lines in your changes missing coverage. Please review.

Project coverage is 24.36%. Comparing base (23ca1b3) to head (7372110).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...g/app/pipedv1/plugin/kubernetes/provider/loader.go 44.33% 52 Missing and 7 partials ⚠️
...app/pipedv1/plugin/kubernetes/provider/resource.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5284      +/-   ##
==========================================
+ Coverage   24.31%   24.36%   +0.04%     
==========================================
  Files         440      442       +2     
  Lines       46784    46902     +118     
==========================================
+ Hits        11374    11426      +52     
- Misses      34507    34566      +59     
- Partials      903      910       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 2f86f7d into master Oct 22, 2024
18 checks passed
@Warashi Warashi deleted the k8s-plugin-determinestrategy branch October 22, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants