Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5344 #5351 #5352

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

What this PR does / why we need it:
Cherry pick of #5344 #5351.

HoangNguyen689 and others added 2 commits November 20, 2024 04:27
…rift detection (#5344)

* Handle ECS Apps DeploymentConfiguration and containers Environments driff detection

Signed-off-by: HoangNguyen689 <[email protected]>

* applied

Signed-off-by: HoangNguyen689 <[email protected]>

---------

Signed-off-by: HoangNguyen689 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
@ffjlabo
Copy link
Member

ffjlabo commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.04%. Comparing base (7bbc4d5) to head (38b77b0).
Report is 1 commits behind head on release-v0.49.x.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.49.x    #5352      +/-   ##
===================================================
+ Coverage            23.02%   23.04%   +0.02%     
===================================================
  Files                  418      418              
  Lines                45133    45146      +13     
===================================================
+ Hits                 10390    10403      +13     
  Misses               33948    33948              
  Partials               795      795              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it. The rest PRs are already merged as rc.

@ffjlabo
Copy link
Member

ffjlabo commented Nov 20, 2024

@t-kikuc

I got it. The rest PRs are already merged as rc.

Yes, thank you for your confirmation 🙏
I also include these fixes in the rc versions below

@ffjlabo ffjlabo merged commit af2d227 into release-v0.49.x Nov 20, 2024
15 of 17 checks passed
@ffjlabo ffjlabo deleted the cherry-pick-#5344-#5351-to-release-v0.49.x branch November 20, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants