refactor: Applied docker build practices #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponkio-o
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
ponkio-o
commented
Nov 30, 2024
| @@ -1,3 +1,4 @@ | |||
| # check=skip=SecretsUsedInArgOrEnv | |||
There was a problem hiding this comment.
The following code was pointed out to me, but I ignored it because it was a false positve.
pipecd/tool/piped-base-okd/Dockerfile
Line 39 in a532718
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: ponkio-o <[email protected]>
Signed-off-by: Cuong Vu <[email protected]> Signed-off-by: ponkio-o <[email protected]>
ponkio-o
force-pushed
the
refactor-dockerfile
branch
from
d154f2d to
9f50256
Compare
t-kikuc
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: To follow docker best practices.
This PR applied the following practices:
Why we need it: To avoid future errors
Which issue(s) this PR fixes: None
Does this PR introduce a user-facing change?: No