Implement preparing manifest applier in kubernetes plugin #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
commented
Dec 4, 2024
| @@ -33,10 +35,20 @@ import ( | |||
| "google.golang.org/grpc/status" | |||
| ) | |||
|
|
|||
| const ( | |||
| defaultKubectlVersion = "1.18.2" | |||
There was a problem hiding this comment.
This is copied from current implementation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
- Coverage 25.85% 25.84% -0.02%
==========================================
Files 448 448
Lines 48261 48281 +20
==========================================
Hits 12478 12478
- Misses 34812 34832 +20
Partials 971 971 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR implements the preparation of a manifest applier in the Kubernetes plugin.
Why we need it:
Without this PR, we cannot execute the K8S_SYNC stage.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No