Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish_tool ci #5403

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix publish_tool ci #5403

merged 2 commits into from
Dec 10, 2024

Conversation

ponkio-o
Copy link
Contributor

What this PR does: I forgot to fix the CI where docker push is executed 😅

Why we need it: To publish linux/arm64 images

Which issue(s) this PR fixes:

related: #5395

Does this PR introduce a user-facing change?: No

@ponkio-o
Copy link
Contributor Author

In my assumption, when this PR is merged into the master branch, a container image compatible with linux/arm64 will be published on ghcr. After that, I plan to change the base image and make various container images compatible with arm64.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@t-kikuc t-kikuc enabled auto-merge (squash) December 10, 2024 04:56
@t-kikuc t-kikuc merged commit e276b89 into pipe-cd:master Dec 10, 2024
15 checks passed
@ponkio-o ponkio-o deleted the fix-publish-ci branch December 10, 2024 05:01
@ponkio-o
Copy link
Contributor Author

👍

$ docker manifest inspect ghcr.io/pipe-cd/piped-base:v0.50.0-22-ge276b89
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 673,
         "digest": "sha256:049d563d3e89e19d2d6465f0ab9aa923b9dd448b5172698e3488b0d367cdcfb6",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 673,
         "digest": "sha256:2d8b7e1ad6da1ef34df28548dade7af28b3b25f5b97c30b3b645aa9e50ba86e5",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 566,
         "digest": "sha256:3d3387cef4f26c719a0376be86d4320c46fb137d1f41ac60b539be3f79e20bc2",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 566,
         "digest": "sha256:23e7bc9c3ff826977b382a488c58b14e46ef2c8f305521cc5ed62fbb31feb8bc",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants