-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate mock file using uber-go mock #5437
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
+ Coverage 26.24% 26.26% +0.02%
==========================================
Files 452 452
Lines 48860 48860
==========================================
+ Hits 12821 12831 +10
+ Misses 35014 35005 -9
+ Partials 1025 1024 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Update mock files by regenerating using the updated codegen image.
Also, fix the tests to use uber-go mock instead of golang mock.
Why we need it:
Which issue(s) this PR fixes:
Fixes #5429
Follow PR #5426
Does this PR introduce a user-facing change?: