Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logging in EventWatcher #5443

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Enhance logging in EventWatcher #5443

merged 2 commits into from
Dec 23, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 23, 2024

What this PR does:

  1. Add logger.Error() before returning (cedc8f2)
  2. Add some git info in logger.Error(). (7dd40c7)

IMO, we should add a logger to git.Repo too.

Why we need it:

  • To make debugging EventWatcher easier
  • To follow the new logging convention

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 26.24%. Comparing base (bcdba1f) to head (7dd40c7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/eventwatcher/eventwatcher.go 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5443      +/-   ##
==========================================
- Coverage   26.25%   26.24%   -0.01%     
==========================================
  Files         452      452              
  Lines       48860    48886      +26     
==========================================
+ Hits        12827    12831       +4     
- Misses      35008    35031      +23     
+ Partials     1025     1024       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@t-kikuc t-kikuc merged commit e00b429 into master Dec 23, 2024
16 of 18 checks passed
@t-kikuc t-kikuc deleted the log-eventwatcher-enhance branch December 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants