Remove key field from provider.Manifest in the k8s plugin
#5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…ent service Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
…tion Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
commented
Dec 24, 2024
Comment on lines
+202
to
+208
| // decode and override the autoCreateNamespace and namespace | ||
| spec, err := config.DecodeYAML[*kubeConfigPkg.KubernetesApplicationSpec](cfg) | ||
| require.NoError(t, err) | ||
| spec.Spec.Input.AutoCreateNamespace = true | ||
| spec.Spec.Input.Namespace = "test-namespace" | ||
| cfg, err = yaml.Marshal(spec) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
override example config to ensure these fields are used when applying the resources
| require.NoError(t, err) | ||
| assert.Equal(t, model.StageStatus_STAGE_SUCCESS.String(), resp.GetStatus().String()) | ||
|
|
||
| deployment, err := dynamicClient.Resource(schema.GroupVersionResource{Group: "apps", Version: "v1", Resource: "deployments"}).Namespace("test-namespace").Get(context.Background(), "simple", metav1.GetOptions{}) |
There was a problem hiding this comment.
check the resource in the namespace test-namespace
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5446 +/- ##
==========================================
+ Coverage 26.23% 26.24% +0.01%
==========================================
Files 452 452
Lines 48872 48859 -13
==========================================
+ Hits 12823 12825 +2
+ Misses 35024 35010 -14
+ Partials 1025 1024 -1 ☔ View full report in Codecov by Sentry. |
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
t-kikuc
approved these changes
Dec 25, 2024
ffjlabo
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
keyfield fromprovider.Manifestof k8s plugin, and make it inKey()methodWhy we need it:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No