Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy target name to the resource state #5453

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Dec 26, 2024

What this PR does:

Added deploy_target to show the livestate grouped by it on the Web UI.

Why we need it:

In the multicluster support, we introduce multi-targets in one app.

Which issue(s) this PR fixes:

Part of #5363, #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.14%. Comparing base (792015b) to head (15a0e25).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5453      +/-   ##
==========================================
- Coverage   26.15%   26.14%   -0.02%     
==========================================
  Files         456      456              
  Lines       48992    48992              
==========================================
- Hits        12814    12808       -6     
- Misses      35156    35162       +6     
  Partials     1022     1022              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo marked this pull request as ready for review December 26, 2024 02:40
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

It's simpler to use deploy_target than the root node for GENERIC UI.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit f6a472e into master Dec 26, 2024
17 of 18 checks passed
@ffjlabo ffjlabo deleted the add-deploy-target-to-resource-state branch December 26, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants