Implement resource pruning in k8s plugin #5455
Open
+1,311
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5455 +/- ##
==========================================
+ Coverage 26.15% 26.16% +0.01%
==========================================
Files 456 457 +1
Lines 48992 49285 +293
==========================================
+ Hits 12814 12896 +82
- Misses 35156 35363 +207
- Partials 1022 1026 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
commented
Dec 26, 2024
Comment on lines
89
to
90
| // Set the namespace for all manifests. | ||
| manifests[i].body.SetNamespace(input.Namespace) |
There was a problem hiding this comment.
We need this to ensure the loaded manifests' namespaces are matched with applied resource.
There was a problem hiding this comment.
Oops, we have to check the input.Namespace is empty or not.
Comment on lines
+92
to
+98
| // Add builtin labels and annotations for tracking application live state. | ||
| manifests[i].AddLabels(map[string]string{ | ||
| LabelManagedBy: ManagedByPiped, | ||
| LabelPiped: input.PipedID, | ||
| LabelApplication: input.AppID, | ||
| LabelCommitHash: input.CommitHash, | ||
| }) |
There was a problem hiding this comment.
I want these labels to retrieve live resources when pruning the resources.
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
to prune the resources which removed in the git repository
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No