Skip to content

Fix dial-in demo: Add callId and callDomain to server payload #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dial-in demo: Add callId and callDomain to server payload #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deployment/pipecat-cloud-daily-pstn-server/fastapi-webhook-server/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,12 @@ async def dial(request: RoomRequest, raw_request: Request):
"createDailyRoom": True,
"dailyRoomProperties": daily_room_properties,
"body": {
"dialin_settings": dialin_settings,
"dialout_settings": request.dialout_settings,
"voicemail_detection": request.voicemail_detection,
"call_transfer": request.call_transfer,
"sip_headers": request.sipHeaders, # passing the SIP headers to the bot
"callId": request.callId,
"callDomain": request.callDomain,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have broken the bot, because we need to send the other params to the bot as well... To and From. Is the bot not expecting dialin_settings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vr000m you're right, it's not expecting dialin_settings. I wasn't sure if I needed to change the definition of the Python types in this file or change the bot file. I opted for this file but I can change the bot file instead.

},
}

Expand Down
4 changes: 2 additions & 2 deletions phone-chatbot/daily-pstn-dial-in/bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ async def bot(runner_args: RunnerArguments):
"""Main bot entry point compatible with Pipecat Cloud."""
# Body is always a dict (compatible with both local and Pipecat Cloud)
body_data = runner_args.body
room_url = body_data.get("room_url")
token = body_data.get("token")
room_url = runner_args.room_url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue running this demo as is (uv.lock is using 0.0.85, but we haven't changed anything in this area in a bit).

I'm intentionally creating a room out of band from Pipecat Cloud and passing to my bot. This allows the room to be created with the correct SIP parameters.

Are you seeing an issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markbackman, running as is on Pipecat Cloud doesn't work. It works locally just fine on main. This was the only way I was able to get it to work on Pipecat Cloud.

body_data does not contain token or room_url 🤷

token = runner_args.token
call_id = body_data.get("callId")
call_domain = body_data.get("callDomain")

Expand Down