done sent message to elevenlabs when closing connection #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aconchillo do you know why we were sending |
|
@markbackman @aconchillo any update on the same ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
Fix: Prevent further errors when closing ElevenLabs WebSocket connection
We now ensure that no additional messages are sent to ElevenLabs after an error occurs in the WebSocket connection. Previously, sending messages to an already errored-out connection caused further errors and prevented the WebSocket from closing cleanly. This issue was observed multiple times, resulting in failures to reconnect to ElevenLabs. This fix improves error handling and ensures seamless reconnection.