Add Whisper STT service using OpenAI API #1128
Merged
+76
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Feb 5, 2025
| await self.start_ttfb_metrics() | ||
|
|
||
| response: Transcription = await self._client.audio.transcriptions.create( | ||
| file=("audio.wav", audio, "audio/wav"), model=self.model_name |
There was a problem hiding this comment.
Does this save a file to disk? We should not add that by default, probably an argument to the constructor, like save_audio_file: Optional[str]: None.
There was a problem hiding this comment.
Ooops, duh! Sorry, I misread the code!
aconchillo
approved these changes
Feb 5, 2025
|
LGTM! @golbin Do you mind fixing the conflicts? 🙏 |
|
@aconchillo I resolved the conflict |
|
@aconchillo everything OK? |
|
Thanks @golbin! |
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch originates from #459 but has been stuck for a while, so I created this version with a small fix.