Skip to content

Conversation

@kennethtegrado
Copy link

Changes

  • Add language_options, identify_language, and identify_multiple_languages
  • Update query params when creating signed_url
  • Use LanguageCode as argument when creating TranscriptionFrame and InterimTranscriptionFrame

Ref #2847


_REVERSE_LANGUAGE_MAP = None # Will be initialized after class definition

def service_language_to_language(self, service_language: str) -> Language | None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this utility function and the related ones outside of the class definition.

Nit: ideally, you could use the same utility function we have in other services. This helps with maintenance. Ex:
https://github.com/pipecat-ai/pipecat/blob/main/src/pipecat/services/elevenlabs/stt.py#L28-L150

@markbackman
Copy link
Contributor

Can you also install the pre-commit hook to check for linting issues?

uv run pre-commit install

You can also run the fix-ruff.sh or pre-commit.sh scripts independent from the hook.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 14.58333% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/services/aws/utils.py 2.27% 43 Missing ⚠️
src/pipecat/services/aws/stt.py 25.00% 39 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/services/aws/stt.py 20.60% <25.00%> (+2.74%) ⬆️
src/pipecat/services/aws/utils.py 9.37% <2.27%> (-1.27%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kennethtegrado
Copy link
Author

I'll update @markbackman based on your review thanks

@markbackman
Copy link
Contributor

Also, can you please make only essential changes and stick to the current code structure as best as possible. This will help make code reviewing easier and will make maintenance easier as this service will align with other STT services.

@kennethtegrado
Copy link
Author

Updated @markbackman and I tried to copy the code structure of other services as much as I can

@kennethtegrado kennethtegrado force-pushed the feat/aws-language-options branch from db0f66d to cb2e5a2 Compare October 14, 2025 17:24
@kennethtegrado kennethtegrado force-pushed the feat/aws-language-options branch from cb2e5a2 to 1b18abb Compare October 14, 2025 17:47
@kennethtegrado
Copy link
Author

Hi @markbackman any updates on this PR thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants