-
Couldn't load subscription status.
- Fork 1.4k
Add language options in AWS Transcribe STT Service #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add language options in AWS Transcribe STT Service #2849
Conversation
src/pipecat/services/aws/stt.py
Outdated
|
|
||
| _REVERSE_LANGUAGE_MAP = None # Will be initialized after class definition | ||
|
|
||
| def service_language_to_language(self, service_language: str) -> Language | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this utility function and the related ones outside of the class definition.
Nit: ideally, you could use the same utility function we have in other services. This helps with maintenance. Ex:
https://github.com/pipecat-ai/pipecat/blob/main/src/pipecat/services/elevenlabs/stt.py#L28-L150
|
Can you also install the pre-commit hook to check for linting issues? You can also run the fix-ruff.sh or pre-commit.sh scripts independent from the hook. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
|
I'll update @markbackman based on your review thanks |
|
Also, can you please make only essential changes and stick to the current code structure as best as possible. This will help make code reviewing easier and will make maintenance easier as this service will align with other STT services. |
|
Updated @markbackman and I tried to copy the code structure of other services as much as I can |
db0f66d to
cb2e5a2
Compare
cb2e5a2 to
1b18abb
Compare
|
Hi @markbackman any updates on this PR thank you! |
Changes
language_options,identify_language, andidentify_multiple_languagesLanguageCodeas argument when creatingTranscriptionFrameandInterimTranscriptionFrameRef #2847