DailyTransport: update start_dialout/start_recording return values #2911
+264
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
commented
Oct 23, 2025
| logger.info(f"Joined {self._room_url}") | ||
|
|
||
| if self._params.transcription_enabled: | ||
| await self.start_transcription(self._params.transcription_settings) |
There was a problem hiding this comment.
We now do this in on_joined callback instead of in the join function itself. I think it's much cleaner that burying things.
aconchillo
commented
Oct 23, 2025
| await self._callbacks.on_before_leave() | ||
|
|
||
| if self._params.transcription_enabled: | ||
| await self.stop_transcription() |
There was a problem hiding this comment.
Same here. We just stop transcription in on_before_leave. Good thing we added support for that!
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
aconchillo
force-pushed
the
aleix/daily-transport-improve-error-handling
branch
3 times, most recently
from
b7cd22b to
e26d5e3
Compare
aconchillo
force-pushed
the
aleix/daily-transport-improve-error-handling
branch
from
e26d5e3 to
f2f725d
Compare
aconchillo
force-pushed
the
aleix/daily-transport-improve-error-handling
branch
from
f2f725d to
d62443c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
A few updates:
start_dialoutandstart_recording, which are now(session_id, error)or(recording_id, error).daily-pythonfunction called.