Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put default value within aggregate #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vmx
Copy link
Member

@vmx vmx commented Dec 14, 2017

Prior to this change, default values for aggregates were specified
as:

max(.foo) default=5

The new syntax is putting the default value within the aggregate
function:

max(.foo default=5)

This makes more sense as the default value is not a single value
for the max() function, but it is applied to every Keypath
within the max() function.

It is also more symmetrical to the default values for returns.
There it's also , e.g.:

return .foo default=5

This is part of #51.

Prior to this change, default values for aggregates were specified
as:

    max(.foo) default=5

The new syntax is putting the default value within the aggregate
function:

    max(.foo default=5)

This makes more sense as the default value is not a single value
for the `max()` function, but it is applied to every Keypath
*within* the `max()` function.

It is also more symmetrical to the default values for returns.
There it's also <Keypath> <space> <default>, e.g.:

    return .foo default=5

This is part of pipedown#51.
@vmx vmx requested a review from Damienkatz December 14, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant