Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI for compilation check #15

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

livibetter
Copy link
Contributor

@livibetter livibetter commented Feb 20, 2018

  • Build on Linux and OS X with Clang and GCC.
  • Install autoconf-archive-2017.03.21 (for AX_IS_RELEASE(dash-version)).
  • Cache autoconf-archive for 1 day.

Here is the build result.

As we don't have tests (well, not sure how we can do that), this CI is only for the compilation and make install. Invoking Snakes with -h (or -v soon) wouldn't mean much, nor would { sleep 0.1 ; yes ; } | ./snake (with #14), it runs and that's all.

The caching actually slows down each build for about 10 to 20 seconds, but it won't be downloading autoconf-archive 4 times in every push.

I honestly don't know if we should cache or not, if @StefansM prefers not, I can remove the commit for caching.

Expected to fail due to the lack of autoconf-archive.
The approach is to use the tarball for the 2017.03.21, as it's the
minimal version for dash-version policy of AX_IS_RELEASE macro.

Although we can use APT to install autoconf-archive, but it won't work
for OSX build, and cloning Git takes more time than a simple tarball.
@StefansM
Copy link
Contributor

Looks good. I don't see a benefit to caching, as it should be faster to download the .xz from GNU than the uncompressed files from S3.

@livibetter
Copy link
Contributor Author

The commit for caching is removed. (build result)

@StefansM StefansM merged commit 24c1b84 into pipeseroni:master Feb 21, 2018
@StefansM
Copy link
Contributor

Excellent -- nice work. Is there anything extra that needs to be configured to set this up?

@livibetter
Copy link
Contributor Author

Not sure if it's same for repo in organization, but in personal account, I do like:

  • Go to Settings
  • Integration something?
  • Add Service > Travis CI
  • Click the link that leads to Travis CI's websites
  • [Sync repos] > Tap on the switch to turn on

Once turned on, the CI will build on the next push.

@StefansM
Copy link
Contributor

Okay, I've requested organisation access via the Travis CI website. For some reason, my account has been flagged as abusive (??? -- I only just signed up, and I just tried build a fork of pipes.c) so I will have to wait for support to get back to me.

@livibetter livibetter removed the request for review from StefansM February 21, 2018 13:03
@livibetter
Copy link
Contributor Author

@StefansM That's weird. I hope you get that sorted out soon and no harms done to your account. But who flagged you? GitHub or Travis CI?

And I've just received an email about Travis CI requests access to our private data, which link did you click on? travis-ci.org or .com (for private repos)? It should be the former.

I am holding off the request for approval because I don't want to grant the access to the private data, even we have none, if you did click on the wrong one, which I'd believe so, although I have no experience of turning on in a organization's repo.

@livibetter livibetter deleted the add-travis-ci branch February 21, 2018 13:04
@StefansM
Copy link
Contributor

@livibetter Yes, very strange. It's Travis CI that flagged me. I hope to hear back from them soon, otherwise I guess I'm stuck.

I thought I used .org, but I could be mistaken. I regenerated the Travis CI auth token for my GitHub account and Travis CI didn't ask me for access to my private repos when I signed back in. Maybe you should reject the request and I can send another one.

@livibetter
Copy link
Contributor Author

@StefansM done.

@StefansM
Copy link
Contributor

OK, I've resent the request.

@livibetter
Copy link
Contributor Author

I didn't receive another email, but it'd seem that access has to be granted.

Travis CI uses read:org, so I've granted it.

@StefansM
Copy link
Contributor

I heard back from Travis CI support in impressively quick time. Apparently they were making some changes to their infrastructure and mistakenly flagged my account. All fixed now and set up.

@StefansM StefansM mentioned this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants