Fix call to attr_set for ncurses < 6
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ncurses with ABI >= 6 support passing a color index to `attr_set` through the `opts` pointer. This work-around is because the `params` pointer must remain a `short` for backwards compatibility and the `opts` pointer has never actually been used for anything else. This commit adds an explicit ABI version check that uses the `params` field when ncurses major version is < 6. I've used an explicit preprocessor guard rather than always calling `attr_set(..., p->color, &p->color)` because `p->color` is an `int`, and it would overflow when passed as the `short params` argument. Probably not a problem in practice, but easy to avoid nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ncurses with ABI >= 6 support passing a color index to
attr_setthrough the
optspointer. This work-around is because theparamspointer must remain a
shortfor backwards compatibility and theoptspointer has never actually been used for anything else.
This commit adds an explicit ABI version check that uses the
paramsfield when ncurses major version is < 6. I've used an explicit
preprocessor guard rather than always calling
attr_set(..., p->color, &p->color)becausep->coloris anint, and it would overflow whenpassed as the
short paramsargument. Probably not a problem inpractice, but easy to avoid nonetheless.
Tested on Red Hat 7, which is where I noticed the original bug.