Fix build on NetBSD using native curses

[travispaul]

In file included from src/render.h:6:0,
                 from src/render.c:13:
src/pipe.h:32:5: error: 'UP' redeclared as different kind of symbol
     UP = 3
     ^
In file included from /usr/include/term.h:2002:0,
                 from src/render.c:11:
/usr/include/termcap.h:45:14: note: previous declaration of 'UP' was here
 extern char *UP;
              ^
*** Error code 1

When building with NetBSD's native curses library an included header: termcap.h already has an extern symbol named "UP" which conflicts with the "DIRECTIONS" enum.

[travispaul]

Looks like moving the enum breaks the tests in t/locale.c...

Would you have any suggestions or preference for avoiding this conflict?

• Rename the enum members?
• Redefine the enum again in locale.c?

Neither of those sound like great solutions.

Thanks

[StefansM]

Hi @travispaul,

Thanks for testing on netbsd. I'm interested to see what else ends up breaking, as some of the code is probably quite ncurses-specific.

I'd like to keep the DIRECTIONS enum in the header so that it can be used in the test programs. How about adding a CPIPES_ prefix to each member as a rudimentary namespace?

[travispaul]

Hi @StefansM,

That works for me, I'll do some further testing this week and report anything I find but so far it works in ascii mode. I have also been able to trigger a segfault with the wrong TERM set but that seems like it may be an issue with NetBSD curses not cpipes.

[StefansM]

Excellent, thanks.