-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow-up to #1052 #1053
Follow-up to #1052 #1053
Conversation
Also drop Pre-Depends: ${misc:Pre-Depends} from libpistache-dev, as it is only used in shared libraries, and drop python3-distutils because Pistache doesn't call import('python').find_installation() in Meson anymore The bump may break compatibility with old Ubuntu releases
Now we'll see if this actually breaks Ubuntu builds :) |
So for Jammy it builds, but it fails to upload due to what looks like the versioning in the file name. For the older Focal, it looks like we're going to have to drop support for it because its missing the debhelper-compat (= 13). That's not really critical though because we don't have an official stable release yet anyways so no need to support older releases. |
Yeah pushing multiple builds in the same day isn't really supported by the classic
Oh I thought Focal did support dh 13, or that at least it got backported, being a supported release :/ |
And it is in fact supported in focal-backports. Is it possible to build packages using backports in the PPA? Edit: wow, it is even available in bionic-backports! |
Good call. I've added backports to both the stable and unstable PPAs. Let me try rebuilding now for all. The upload failure we can ignore for now, but let's see if it at least builds. I've also added bionic just for shit kicks to see if it works. |
Ok it looks like it's building for Jammy, Impish, and Focal - but not Bionic. That's ok. That's reasonable. Bionic is nearly half a decade old. There's still the upload error, but that should disappear when I try again tomorrow. |
I think that's reasonable too. Could you link me the logs, please? I'm unable to find them Edit: nevermind, found them here: https://launchpad.net/~pistache+team/+archive/ubuntu/unstable/+builds?build_text=&build_state=all Bionic wasn't able to build Pistache even before this change because it only ships Meson 0.45.1 |
Weird. You should be getting the build failure logs emailed to you because you're on the Launchpad team. As for logs and manually triggering a rebuild, try here. |
I believe I only get emailed about build failures related to daily automated builds and builds that I manually trigger. I seem to remember that you didn't receive a bunch of build failures that I manually triggered some months ago either |
Yeah that would make sense. |
Hey @Tachi107. I noticed from observing the CI failures in #1054 and #1040 that it looks like it is failing because we're still running them in Focal, but:
I think you can bump the CI test bed to Jammy, since it's the new LTS. Once that's done, @IHni3 can rebase and I'll trigger CI to restart. |
Actually I think that the CI doesn't need the build deps at all, as it
only runs `dpkg-source --build` while the actual binary build is
executed in the Debian Testing autopkgtest image. I'll submit a PR
fixing it soon
Edit: submitted as #1055
|
No description provided.