Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #1052 #1053

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Follow-up to #1052 #1053

merged 2 commits into from
Apr 19, 2022

Conversation

Tachi107
Copy link
Member

No description provided.

Also drop Pre-Depends: ${misc:Pre-Depends} from libpistache-dev, as it
is only used in shared libraries, and drop python3-distutils because
Pistache doesn't call import('python').find_installation() in Meson anymore

The bump may break compatibility with old Ubuntu releases
@kiplingw kiplingw merged commit 04f8d14 into pistacheio:debian Apr 19, 2022
@Tachi107 Tachi107 deleted the debian branch April 19, 2022 20:11
@Tachi107
Copy link
Member Author

Now we'll see if this actually breaks Ubuntu builds :)

@kiplingw
Copy link
Member

So for Jammy it builds, but it fails to upload due to what looks like the versioning in the file name.

For the older Focal, it looks like we're going to have to drop support for it because its missing the debhelper-compat (= 13). That's not really critical though because we don't have an official stable release yet anyways so no need to support older releases.

@Tachi107
Copy link
Member Author

So for Jammy it builds, but it fails to upload due to what looks like the versioning in the file name.

Yeah pushing multiple builds in the same day isn't really supported by the classic +git<date>.<hash> format

For the older Focal, it looks like we're going to have to drop support for it because its missing the debhelper-compat (= 13). That's not really critical though because we don't have an official stable release yet anyways so no need to support older releases.

Oh I thought Focal did support dh 13, or that at least it got backported, being a supported release :/

@Tachi107
Copy link
Member Author

Tachi107 commented Apr 19, 2022

Oh I thought Focal did support dh 13, or that at least it got backported, being a supported release :/

And it is in fact supported in focal-backports. Is it possible to build packages using backports in the PPA?

Edit: wow, it is even available in bionic-backports!

@kiplingw
Copy link
Member

Good call. I've added backports to both the stable and unstable PPAs. Let me try rebuilding now for all. The upload failure we can ignore for now, but let's see if it at least builds. I've also added bionic just for shit kicks to see if it works.

@kiplingw
Copy link
Member

Ok it looks like it's building for Jammy, Impish, and Focal - but not Bionic. That's ok. That's reasonable. Bionic is nearly half a decade old. There's still the upload error, but that should disappear when I try again tomorrow.

@Tachi107
Copy link
Member Author

Tachi107 commented Apr 19, 2022

Ok it looks like it's building for Jammy, Impish, and Focal - but not Bionic. That's ok. That's reasonable. Bionic is nearly half a decade old. There's still the upload error, but that should disappear when I try again tomorrow.

I think that's reasonable too. Could you link me the logs, please? I'm unable to find them

Edit: nevermind, found them here: https://launchpad.net/~pistache+team/+archive/ubuntu/unstable/+builds?build_text=&build_state=all

Bionic wasn't able to build Pistache even before this change because it only ships Meson 0.45.1

@kiplingw
Copy link
Member

Weird. You should be getting the build failure logs emailed to you because you're on the Launchpad team.

As for logs and manually triggering a rebuild, try here.

@Tachi107
Copy link
Member Author

Weird. You should be getting the build failure logs emailed to you because you're on the Launchpad team.

I believe I only get emailed about build failures related to daily automated builds and builds that I manually trigger. I seem to remember that you didn't receive a bunch of build failures that I manually triggered some months ago either

@kiplingw
Copy link
Member

Yeah that would make sense.

@kiplingw
Copy link
Member

Hey @Tachi107. I noticed from observing the CI failures in #1054 and #1040 that it looks like it is failing because we're still running them in Focal, but:

The following packages have unmet dependencies:
 builddeps:. : Depends: debhelper-compat (= 13)
E: Unable to correct problems, you have held broken packages.
Error: Process completed with exit code 100.

I think you can bump the CI test bed to Jammy, since it's the new LTS. Once that's done, @IHni3 can rebase and I'll trigger CI to restart.

@Tachi107
Copy link
Member Author

Tachi107 commented Apr 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants