Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid https_client_test_net Hang If No Network #1301

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

dgreatwood
Copy link
Collaborator

We avoid the test hangs seen previously by catching the exception that Pistache generates if there is no network connected.

Also - Added a test to check that the exception is correctly generated if the client tries to connect to a non-existent URI.

We avoid the test hangs seen previously by catching the exception that
Pistache generates if there is no network connected.

Also - Added a test to check that the exception is correctly generated
if the client tries to connect to a non-existent URI.
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.33%. Comparing base (94be9f0) to head (a0301c5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
+ Coverage   75.97%   76.33%   +0.35%     
==========================================
  Files          63       64       +1     
  Lines        9851    10972    +1121     
==========================================
+ Hits         7484     8375     +891     
- Misses       2367     2597     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kiplingw kiplingw requested review from kiplingw and Tachi107 March 16, 2025 19:44
@kiplingw kiplingw added bug http_client Issues pertaining to pistache's HTTP client unit / CI testing For unit testing and CI (including DEP-8) labels Mar 16, 2025
@dgreatwood dgreatwood merged commit ea6b7dd into pistacheio:master Mar 16, 2025
159 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug http_client Issues pertaining to pistache's HTTP client unit / CI testing For unit testing and CI (including DEP-8)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants