Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
@nahsra
nahsra committed Aug 29, 2023
1 parent 8d285b0 commit c1db982
Showing 1 changed file with 55 additions and 69 deletions.
124 changes: 55 additions & 69 deletions .../codemodder-plugin-maven/src/test/java/io/codemodder/plugins/maven/MavenProviderTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,31 +23,17 @@
* types.
*/
final class MavenProviderTest {
private static class PomModification {
final Path path;

final byte[] contents;
private DependencyDescriptor defaultDescriptor;

public PomModification(Path path, byte[] contents) {
this.path = path;
this.contents = contents;
}

public Path getPath() {
return path;
}

public byte[] getContents() {
return contents;
}
}
private record PomModification(Path path, byte[] contents) {}

private static class TestPomModifier implements MavenProvider.PomModifier {

private final List<PomModification> modifications = new ArrayList<>();

@Override
public void modify(Path path, byte[] contents) throws IOException {
public void modify(Path path, byte[] contents) {
this.modifications.add(new PomModification(path, contents));
}

Expand Down Expand Up @@ -97,6 +83,7 @@ public List<PomModification> getModifications() {
void setup(final @TempDir Path projectDir) throws IOException {

this.projectDir = projectDir;
this.defaultDescriptor = DependencyDescriptor.createMarkdownDescriptor();

marsJavaFile = this.projectDir.resolve("module1/src/main/java/com/acme/Mars.java");
venusJavaFile = this.projectDir.resolve("module1/src/main/java/com/acme/Venus.java");
Expand Down Expand Up @@ -153,15 +140,13 @@ void setup(final @TempDir Path projectDir) throws IOException {

@Test
void it_returns_changeset_when_no_issues() throws IOException {
CodeTFChangesetEntry changesetEntry =
new CodeTFChangesetEntry(marsJavaFile.toString(), "diff here", List.of());

Files.writeString(module1Pom, simplePom);

MavenProvider provider =
new MavenProvider(
new MavenProvider.DefaultPomModifier(),
new MavenProvider.DefaultPomFileFinder(),
defaultDescriptor,
false);

DependencyUpdateResult result =
Expand All @@ -172,7 +157,7 @@ void it_returns_changeset_when_no_issues() throws IOException {
assertThat(result.erroredFiles()).isEmpty();

// we've updated all the poms, so we merge this with the pre-existing one change
assertThat(result.packageChanges().size() == 2);
assertThat(result.packageChanges().size()).isEqualTo(2);

// we injected all the dependencies, total success!
assertThat(result.injectedPackages()).containsOnly(marsDependency1, marsDependency2);
Expand All @@ -182,7 +167,8 @@ void it_returns_changeset_when_no_issues() throws IOException {
void it_returns_empty_when_no_pom() throws IOException {
when(pomFileFinder.findForFile(any(), any())).thenReturn(Optional.empty());

MavenProvider provider = new MavenProvider(pomModifier, pomFileFinder, false);
MavenProvider provider =
new MavenProvider(pomModifier, pomFileFinder, defaultDescriptor, false);

DependencyUpdateResult result =
provider.updateDependencies(projectDir, marsJavaFile, List.of(marsDependency1));
Expand Down Expand Up @@ -236,7 +222,6 @@ void it_handles_pom_update_failure() throws IOException {
Files.writeString(module1Pom, simplePom);

// introduce a failure
// when(pomModifier.modify(any(), any())).thenThrow(new IOException("failed to update pom"));
doThrow(new IOException("failed to update pom")).when(pomModifier).modify(any(), any());

MavenProvider provider = new MavenProvider(pomModifier);
Expand All @@ -262,7 +247,7 @@ void it_updates_poms_correctly() throws IOException {
provider.updateDependencies(
projectDir, module1Pom, List.of(marsDependency1, marsDependency2, venusDependency));

assertThat(result.packageChanges().size() == 3);
assertThat(result.packageChanges().size()).isEqualTo(3);

CodeTFChangesetEntry changesetEntry = result.packageChanges().iterator().next();
assertThat(changesetEntry.getPath()).isEqualTo("module1/pom.xml");
Expand Down Expand Up @@ -298,49 +283,50 @@ void it_finds_correct_poms() throws IOException {
+ "</project>";

private static final String simplePomAfterChanges =
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
+ " <project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n"
+ " <modelVersion>4.0.0</modelVersion>\n"
+ " <groupId>link.sharpe</groupId>\n"
+ " <artifactId>mavenproject1</artifactId>\n"
+ " <version>1.0-SNAPSHOT</version>\n"
+ " <dependencyManagement>\n"
+ " <dependencies>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.mars</groupId>\n"
+ " <artifactId>mars1</artifactId>\n"
+ " <version>${versions.mars1}</version>\n"
+ " </dependency>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.mars</groupId>\n"
+ " <artifactId>mars2</artifactId>\n"
+ " <version>${versions.mars2}</version>\n"
+ " </dependency>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.venus</groupId>\n"
+ " <artifactId>venus</artifactId>\n"
+ " <version>${versions.venus}</version>\n"
+ " </dependency>\n"
+ " </dependencies>\n"
+ " </dependencyManagement>\n"
+ " <properties>\n"
+ " <versions.mars1>1.0.1</versions.mars1>\n"
+ " <versions.mars2>1.0.1</versions.mars2>\n"
+ " <versions.venus>1.0.2</versions.venus>\n"
+ " </properties>\n"
+ " <dependencies>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.mars</groupId>\n"
+ " <artifactId>mars1</artifactId>\n"
+ " </dependency>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.mars</groupId>\n"
+ " <artifactId>mars2</artifactId>\n"
+ " </dependency>\n"
+ " <dependency>\n"
+ " <groupId>com.acme.venus</groupId>\n"
+ " <artifactId>venus</artifactId>\n"
+ " </dependency>\n"
+ " </dependencies>\n"
+ " </project>";
"""
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>link.sharpe</groupId>
<artifactId>mavenproject1</artifactId>
<version>1.0-SNAPSHOT</version>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.acme.mars</groupId>
<artifactId>mars1</artifactId>
<version>${versions.mars1}</version>
</dependency>
<dependency>
<groupId>com.acme.mars</groupId>
<artifactId>mars2</artifactId>
<version>${versions.mars2}</version>
</dependency>
<dependency>
<groupId>com.acme.venus</groupId>
<artifactId>venus</artifactId>
<version>${versions.venus}</version>
</dependency>
</dependencies>
</dependencyManagement>
<properties>
<versions.mars1>1.0.1</versions.mars1>
<versions.mars2>1.0.1</versions.mars2>
<versions.venus>1.0.2</versions.venus>
</properties>
<dependencies>
<dependency>
<groupId>com.acme.mars</groupId>
<artifactId>mars1</artifactId>
</dependency>
<dependency>
<groupId>com.acme.mars</groupId>
<artifactId>mars2</artifactId>
</dependency>
<dependency>
<groupId>com.acme.venus</groupId>
<artifactId>venus</artifactId>
</dependency>
</dependencies>
</project>""";
}

0 comments on commit c1db982

Please sign in to comment.