Skip LLM codemods when no service is available #418
Merged
+62
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdavella
force-pushed
the
skip-llm-codemods-gracefully
branch
from
47220e4
to
8991795
Compare
nahsra
reviewed
Jul 11, 2024
| import io.codemodder.RuleSarif; | ||
| import io.codemodder.SarifPluginRawFileChanger; | ||
| import java.util.Objects; | ||
|
|
There was a problem hiding this comment.
Would add a comment here when to use this type since it's public.
core-codemods/src/main/java/io/codemodder/codemods/DefaultCodemods.java
Outdated
Show resolved
Hide resolved
| this.openAI = Objects.requireNonNull(openAI); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Would add a comment here that I think subclassses shouldn't override this without also considering the same logic?
|
nahsra
approved these changes
Jul 11, 2024
drdavella
added a commit
that referenced
this pull request
Jul 11, 2024
This codemod does not inherit from the base class with the existing check so it did not benefit from the work in #418.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.