refactor: labels #26
Open
refactor: labels #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ankormoreankor
force-pushed
the
labels-review
branch
from
f09f752 to
042fee1
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
042fee1 to
fa1e640
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
fa1e640 to
c74aeb6
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
c74aeb6 to
7c51943
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
7c51943 to
62d5abc
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
62d5abc to
6f7f88d
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
6f7f88d to
9026998
Compare
ankormoreankor
force-pushed
the
labels-review
branch
from
9026998 to
1528fbc
Compare
3em
reviewed
Feb 13, 2025
ankormoreankor
force-pushed
the
labels-review
branch
from
a5e0700 to
364d0db
Compare
3em
reviewed
Feb 17, 2025
| setIsLoading(false) | ||
| }, [isDataLoading, setIsLoading, query, enabled]) | ||
|
|
||
| return { isLoading, space_ref, repo_ref } |
There was a problem hiding this comment.
If you have added the loader state for labels to the store, then remove its export from the hook and use the loading status from the store everywhere.
3em
reviewed
Feb 17, 2025
| @@ -18,23 +18,15 @@ export const RepoLabelFormContainer = () => { | |||
| query: labelId, | |||
| enabled: !!labelId | |||
| }) | |||
| console.log('🚀 ~ RepoLabelFormContainer ~ isDataLoading:', isDataLoading) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/a590e36f520d43d39a2565a2485f61f0
Design changes (before/after):
