Error reporting modification

[dcavins]

Switched the plugin over to using $bp->signup->errors instead of $result, because the original approach was registering an error, but wasn't stopping submission of the form. Tested under BP 1.6 & 1.7.

I'm not sure this is the best way, though, so I would appreciate your thoughts.

-David

[dcavins]

Oh, this is more complicated than I thought. On a vanilla BP install, your method allows WP_Errors to do its work on duplicate usernames/e-mail addresses and highlights those fields appropriately, but doesn't seem to prevent form submission/user creation. However, the method I proposed, which does prevent form submission, breaks WP_Errors, so duplicate usernames get a generic BP error message across the top of the form, which is not helpful. (There are several plugins that use the $bp->signup->errors style, and they all appear to break WP_Errors, at least with BP 1.7.)

Sorry for the complication.

[brandondove]

Could that possibly be a bug in BP 1.7?

[dcavins]

Hi Brandon-

I'm not really sure. 1.7's version of bp_core_validate_user_signup is pretty different than 1.6's. I did some testing to see what was actually happening with the error arrays behind the scenes, using a fresh user and a duplicate user to test error states. I've added that as a text file if you're interested in seeing the results.

Truthfully, the method you originally proposed seems perfect and mirrors the methods used in the new version of bp_core_validate_user_signup in 1.7, so I'm not sure why it's not stopping the registration process.

-David