Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kit Routing Rework #56

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Kit Routing Rework #56

wants to merge 11 commits into from

Conversation

pixelmund
Copy link
Owner

@pixelmund pixelmund commented Aug 23, 2022 •
edited
Loading

This PR brings the old SvelteKit Routing back!

under the hood it fakes the necessary +page.svelte/+page.server.js files and the directories.

The Solution is pretty hacky by patching the fs module quite a lot...

Stuff missing / not working:

  • HMR doesn't work - Vite isn't able to detect changes to the route files because we're faking the +page etc. files, i'm sure there is a way to solve this and if anyone knows vite a bit better feel free to help out! Currently we're restarting the dev server on changes...
  • Loader/Actions in Layouts
  • Figure out a weird hydration issue in the Svemix Repo which would cause tests to fail. It works fine on a new project and npm link.
  • Write more tests
  • Documentation

@pixelmund pixelmund marked this pull request as draft August 23, 2022 10:05
@pixelmund pixelmund added help wanted Extra attention is needed important labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pixelmund