#9087 Wait for built-in integration before activating mod in e2e test

[mnholtz]

What does this PR do?

• Part of Investigate CI e2e test flakiness #9087
• Noticed a race with some of the flaky tests where the test runner would click the activation button before the form was pre-populated with the built-in integration
• The proper way to fix would be to disable the button before the form is valid, but I found that to be non-trivial
• This does not address all of Investigate CI e2e test flakiness #9087

[github-actions]

Playwright test results

 124 passed
 2 flaky
 6 skipped

Details

 Open report ↗︎
 132 tests across 44 suites
 11 minutes, 28 seconds
 36c0783
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu

[fungairino]

We have a page object helper method in the modsPage to select an option from the integration dependencies in this activation form.

You could consider extracting some of that common logic for getting a locator handle for any given integration dependency form group. I.e.

await expect(modActivationPage.integrationConfig(0)).toHaveText(/^GIPHY — ✨ Built-in$/)

export class ActivateModPage extends BasePageObject {

  get integrationConfig(index: number) {
    return await this.getByTestId(
        `integration-auth-selector-integrationDependencies.${index}.configId`,
      )
  }

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (8318d74) to head (36c0783).
Report is 257 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9088      +/-   ##
==========================================
+ Coverage   74.24%   74.69%   +0.44%     
==========================================
  Files        1332     1344      +12     
  Lines       40817    41651     +834     
  Branches     7634     7752     +118     
==========================================
+ Hits        30306    31112     +806     
- Misses      10511    10539      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.